svn commit: r218685 - head/sys/dev/acpica

[Jung-uk Kim]

On Monday 14 February 2011 01:33 pm, John Baldwin wrote:
> On Monday, February 14, 2011 12:20:20 pm Matthew D Fleming wrote:
> > Author: mdf
> > Date: Mon Feb 14 17:20:20 2011
> > New Revision: 218685
> > URL: http://svn.freebsd.org/changeset/base/218685
> >
> > Log:
> >   Prevent reading from the ACPI_RESOURCE past its actual end. 
> > For paranoia limit to the size of the ACPI_RESOURCE as well.
>
> I think in practice that len would never be >
> sizeof(ACPI_RESOURCE).
>
> You could probably get by with using a KASSERT() instead:
>
> 	KASSERT(res->Length <= sizeof(ACPI_RESOURCE), "resource too
> large")); bcopy(res, req->acpi_res, res->Length);

We should avoid sizeof(ACPI_RESOURCE).  If you really have to know 
size of a specific resource type, there is a convenience macro, i.e., 
ACPI_RS_SIZE(type).

Jung-uk Kim