svn commit: r228925 - head/sys/mips/cavium

Aleksandr Rybalko ray at dlink.ua
Thu Dec 29 09:34:12 UTC 2011


On Wed, 28 Dec 2011 19:20:31 -0800
Oleksandr Tymoshenko <gonzo at freebsd.org> wrote:

>> On 28/12/2011 2:15 AM, Aleksandr Rybalko wrote:
>> > On Wed, 28 Dec 2011 05:57:03 +0000 (UTC)
>> > Oleksandr Tymoshenko<gonzo at FreeBSD.org>  wrote:
>> >
>> >>> Author: gonzo
>> >>> Date: Wed Dec 28 05:57:03 2011
>> >>> New Revision: 228925
>> >>> URL: http://svn.freebsd.org/changeset/base/228925
>> >>>
>> >>> Log:
>> >>>    - Add generic GPIO driver for Cavium Octeon. At the moment pin
>> >>> definition is hardcoded but will be changed later with more
>> >>> flexible way to define them.
>> 	/* __OCTEON_GPIOVAR_H__ */
>> >
>> > Thank you very much Oleksandr!
>> >
>> > Oleksandr, can you please avoid define board depended futures in
>> > a SoC drivers in future '{ "F/D", 7, GPIO_PIN_INPUT}'? So others
>> > will be able to use driver in different boards w/o modification
>> > (just by define it in hints/FDT or so).
>> 
>> OK, I'll remove it soon. It supposed to be just example.
>> 

Thanks again!

it just confuse peoples a bit, even developers.
i remember adri say "many words" about it when he remove board depended
struct from atheros gpio driver :)

Anyway thanks!
I will try to use/modify it ASAP and will send patches for review to
you and my mentor of course.

-- 
Alexandr Rybalko <ray at dlink.ua> 
aka Alex RAY <ray at ddteam.net>


More information about the svn-src-head mailing list