svn commit: r228874 - head/sys/dev/hwpmc

Doug Barton dougb at FreeBSD.org
Mon Dec 26 20:32:43 UTC 2011


On 12/26/2011 04:50, Justin Hibbits wrote:
> On Dec 26, 2011, at 1:23 AM, Doug Barton wrote:
> 
>> On 12/25/2011 06:29, Bjoern A. Zeeb wrote:
>>> Author: bz
>>> Date: Sun Dec 25 14:29:36 2011
>>> New Revision: 228874
>>> URL: http://svn.freebsd.org/changeset/base/228874
>>>
>>> Log:
>>>  Quite the tinderbox for the holidays.  Remove the assert[1].
>>
>> Shouldn't "Why it's Ok to remove the assert" be part of this commit log?
> 
> When I suggested the removal, I didn't see it as necessary, and was just
> looking to quiet the build for now while I look closer.  Right now, that
> code is never called, as it's only used when configured for sampling,
> and that code was originally just a copy from the hwpmc_amd driver.  I
> will be finishing the sampling code in the new year.

Thank you for the explanation.



-- 

		[^L]

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/



More information about the svn-src-head mailing list