svn commit: r228668 - head/usr.bin/netstat

[David Schultz]

On Sat, Dec 17, 2011, Dimitry Andric wrote:
> On 2011-12-17 23:32, Dimitry Andric wrote:
> > Author: dim
> > Date: Sat Dec 17 22:32:00 2011
> > New Revision: 228668
> > URL: http://svn.freebsd.org/changeset/base/228668
> > 
> > Log:
> >   Revert r228650, and work around the clang false positive with printf
> >   formats in usr.bin/netstat/atalk.c by conditionally adding NO_WFORMAT to
> >   the Makefile instead.
> >   
> >   MFC after:	1 week
> 
> Requested by:	bz

Have you been keeping track of the other hacks you've been
sprinkling throughout the tree to work around clang bugs, e.g.,
the one in fsdb?  It would be unfortunate if someone else has to
waste their time later on figuring out what you did, when we could
just as easily have waited a month for the clang bug to be fixed.

Incidentally, the "bug" you fixed in telnet/utilities.c is also a
false positive; clang doesn't understand that an index into a
string constant is also a string constant.

By the way, I think it's great that you've found so many actual
bugs in the tree.  I'm just complaining about a small subset of
the changes, which fixed non-bugs. :)