svn commit: r228625 - head/usr.bin/csup

[Bjoern A. Zeeb]

On 17. Dec 2011, at 21:56 , Bjoern A. Zeeb wrote:

> 
> On 17. Dec 2011, at 21:54 , Dimitry Andric wrote:
> 
>> On 2011-12-17 22:32, mdf at FreeBSD.org wrote:
>> ...
>>>> In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the
>>>> shared secret, and use long long format to snprintf a time_t.
>>> If casting is necessary, style prefers intmax_t or uintmax_t, since
>>> those are always wide enough.
>> 
>> I don't see anything about that in style(9), maybe it should be added
>> then?  In any case, I only changed the %ld format to %lld, because
>> time_t is int, long or long long depending on arch.  Long long is just
>> the widest type required in this case.
> 
> time_t is not always int.  See sparc64.

gnargh, sorry.  But yes we prefer a well defined type to a type that is different
per arch.  %lld has constantly been a printf problem in the past.

/bz

-- 
Bjoern A. Zeeb                                 You have to have visions!
         Stop bit received. Insert coin for new address family.