svn commit: r228323 - head/lib/libc/stdlib

Bruce Evans brde at optusnet.com.au
Wed Dec 7 17:37:27 UTC 2011


On Wed, 7 Dec 2011, David Chisnall wrote:

> Log:
>  style(9) cleanups.

Thanks, but many style bugs are still visible.

> Modified: head/lib/libc/stdlib/quick_exit.c
> ==============================================================================
> --- head/lib/libc/stdlib/quick_exit.c	Wed Dec  7 15:25:48 2011	(r228322)
> +++ head/lib/libc/stdlib/quick_exit.c	Wed Dec  7 16:12:54 2011	(r228323)
> ...
> @@ -56,26 +53,26 @@ at_quick_exit(void (*func)(void))
> {
> 	struct quick_exit_handler *h = malloc(sizeof(struct quick_exit_handler));

This still has:
- initialization in declaration
- line too long
- sizeof(typename) instead of sizeof(var).  Maybe this is only a style bug
   for me, but for long typename's the verboseness given by sizeof(typename)
   helps implement the previous bug.

>
> -	if (0 == h) {
> +	if (NULL == h)

(h == NULL) would be normal.

> 		return 1;

This return is still missing parentheses.

> -	}
> 	h->cleanup = func;
> 	pthread_mutex_lock(&atexit_mutex);
> 	h->next = handlers;
> 	handlers = h;
> 	pthread_mutex_unlock(&atexit_mutex);
> -	return 0;
> +	return (0);

The one is fixed, so now the style for returns in this file is internally
inconsistent.

Bruce


More information about the svn-src-head mailing list