svn commit: r224842 - head/sys/kern

[Alexander Best]

On Sun Aug 14 11, Niclas Zeising wrote:
> On 2011-08-13 18:03, Robert Watson wrote:
> > Author: rwatson
> > Date: Sat Aug 13 16:03:40 2011
> > New Revision: 224842
> > URL: http://svn.freebsd.org/changeset/base/224842
> > 
> > Log:
> >   When falloc() was broken into separate falloc_noinstall() and finstall(),
> >   a bug was introduced in kern_openat() such that the error from the vnode
> >   open operation was overwritten before it was passed as an argument to
> >   dupfdopen().  This broke operations on /dev/{stdin,stdout,stderr}.  Fix
> >   by preserving the original error number across finstall() so that it is
> >   still available.
> >   
> >   Approved by:	re (kib)
> >   Reported by:	cognet
> > 
> > Modified:
> >   head/sys/kern/vfs_syscalls.c
> > 
> 
> It might be worth mentioning this in UPDATING or similar, since a kernel
> built with clang (I haven't tried gcc) during this window will make it
> impossible to do a buildworld without first rebuilding the kernel with
> this fix. It also seems to break at least portsnap, and possibly other
> tools as well.

+1. please also mention the KPI change to fget()! so many people have had
issues, where 3rd party drivers - mostly the nvidia binary driver - got broken.

cheers.
alex

> 
> Regards!
> -- 
> Niclas Zeising