svn commit: r224683 - head/lib/libthread_db

[Garrett Cooper]

On Sat, Aug 6, 2011 at 1:34 PM, Ruslan Mahmatkhanov <cvs-src at yandex.ru> wrote:
> Marius Strobl wrote on 06.08.2011 21:48:
>>
>> Author: marius
>> Date: Sat Aug  6 17:48:30 2011
>> New Revision: 224683
>> URL: http://svn.freebsd.org/changeset/base/224683
>>
>> Log:
>>   The tid member of struct pthread actually is long so read it as such.
>>   Accessing it as an int causes failure on big-endian LP64, i.e. mips64be,
>>   powerpc64 and sparc64.
>>
>>   Reviewed by: marcel
>>   Approved by: re (kib)
>>   MFC after:   1 week
>>
>> Modified:
>>   head/lib/libthread_db/libthr_db.c
>>
>
> Hi.
> Seems like this or related libthread_db commit breaks the build on i386:
>
> ===> lib/libthr (all)
> ===> lib/libthread_db (all)
> cc -O2 -pipe  -I. -I/usr/src/lib/libthread_db -std=gnu99 -fstack-protector
> -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter
> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type
> -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter
> -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls
> -Wold-style-definition -Wno-pointer-sign -c
> /usr/src/lib/libthread_db/thread_db.c
> cc -O2 -pipe  -I. -I/usr/src/lib/libthread_db -std=gnu99 -fstack-protector
> -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter
> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type
> -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter
> -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls
> -Wold-style-definition -Wno-pointer-sign -c
> /usr/src/lib/libthread_db/arch/i386/libpthread_md.c
> cc -O2 -pipe  -I. -I/usr/src/lib/libthread_db -std=gnu99 -fstack-protector
> -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter
> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type
> -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter
> -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls
> -Wold-style-definition -Wno-pointer-sign -c
> /usr/src/lib/libthread_db/libpthread_db.c
> cc -O2 -pipe  -I. -I/usr/src/lib/libthread_db -std=gnu99 -fstack-protector
> -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter
> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type
> -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter
> -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls
> -Wold-style-definition -Wno-pointer-sign -c
> /usr/src/lib/libthread_db/libthr_db.c
> cc1: warnings being treated as errors
> /usr/src/lib/libthread_db/libthr_db.c: In function 'pt_ta_map_id2thr':
> /usr/src/lib/libthread_db/libthr_db.c:217: warning: passing argument 3 of
> 'thr_pread_long' from incompatible pointer type
> /usr/src/lib/libthread_db/libthr_db.c: In function 'pt_ta_thr_iter':
> /usr/src/lib/libthread_db/libthr_db.c:257: warning: passing argument 3 of
> 'thr_pread_long' from incompatible pointer type
> /usr/src/lib/libthread_db/libthr_db.c: In function 'pt_ta_event_getmsg':
> /usr/src/lib/libthread_db/libthr_db.c:398: warning: passing argument 3 of
> 'thr_pread_long' from incompatible pointer type
> /usr/src/lib/libthread_db/libthr_db.c: In function 'pt_thr_event_getmsg':
> /usr/src/lib/libthread_db/libthr_db.c:702: warning: passing argument 3 of
> 'thr_pread_long' from incompatible pointer type

It's not just i386. It's other architectures like arm, mips, and pc98
according to the tinderbox reports (this list is potentially
incomplete).
-Garett