svn commit: r221053 - head/usr.bin/rlogin

Warner Losh imp at bsdimp.com
Tue Apr 26 13:37:48 UTC 2011


On Apr 26, 2011, at 3:57 AM, Gavin Atkinson wrote:

> On Tue, 2011-04-26 at 04:09 +0000, David E. O'Brien wrote:
>> Author: obrien
>> Date: Tue Apr 26 04:09:20 2011
>> New Revision: 221053
>> URL: http://svn.freebsd.org/changeset/base/221053
>> 
>> Log:
>>  This builds OK using the parent dir's WARNS=6.
>>  [built on both AMD64 and i386]
> 
> As a general rule, just compiling on i386 and amd64 are not sufficient
> to test WARNS bumps.  It's usually sufficient to also crossbuild to a
> platform like sparc64 which has stricter alignment, but for a full test
> a "make universe" is best, as this will also catch other issues (for
> example arm, where char is unsigned).

I read the test log as "not really tested, feel free to back it out if it fails on a different architecture"

:)

Warner



More information about the svn-src-head mailing list