svn commit: r220388 - in head/sys: kern sys

John Baldwin jhb at freebsd.org
Wed Apr 6 17:29:53 UTC 2011


On Wednesday, April 06, 2011 12:59:55 pm Edward Tomasz Napierala wrote:
> Author: trasz
> Date: Wed Apr  6 16:59:54 2011
> New Revision: 220388
> URL: http://svn.freebsd.org/changeset/base/220388
> 
> Log:
>   Add ucred pointer to the SysV-related memory structures.  This is required
>   for racct.
>   
>   Note that after this commit, ipcs(1) needs to be rebuilt.  Otherwise, it will
>   fail with "ipcs: sysctlbyname: kern.ipc.msqids: Cannot allocate memory".
>   
>   Sponsored by:	The FreeBSD Foundation
>   Reviewed by:	kib (earlier version)

Please use this idiom:

	foo->cred = crhold(bar->cred);

instead of:

	crhold(bar->cred);
	foo->cred = bar->cred;

I think this cleaner in terms of readability and semantics.

-- 
John Baldwin


More information about the svn-src-head mailing list