svn commit: r212653 - head/sys/netinet

[Lawrence Stewart]

On 09/15/10 20:39, Andre Oppermann wrote:
> Author: andre
> Date: Wed Sep 15 10:39:30 2010
> New Revision: 212653
> URL: http://svn.freebsd.org/changeset/base/212653
> 
> Log:
>   Change the default MSS for IPv4 and IPv6 TCP connections from an
>   artificial power-of-2 rounded number to their real values specified
>   in RFC879 and RFC2460.
>   
>   From the history and existing comments it appears that the rounded
>   numbers were intended to be advantageous for the kernel and mbuf
>   system.  However this hasn't been the case at for at least a long
>   time.  The mbuf clusters used in tcp_output() have enough space
>   to hold the larger real value for the default MSS for both IPv4 and
>   IPv6.  Note that the default MSS is only used when path MTU discovery
>   is disabled.
>   
>   Update and expand related comments.
>   
>   Reviewed by:	lsteward (including some word-smithing)

For the record, I reviewed and fully support the functional changes made
by this patch, but explicitly objected to and offered an alternate for
the proposed comment wording changes.

Andre, given that we had a disagreement about the comment wording, I
would have preferred it if you had noted in your commit log that I had
raised an objection to or at least not reviewed/endorsed the comment
changes.

It's not important enough an issue to spend any more time on, but I'm a
bit upset to see this committed with an acknowledgement to my review and
word-smithing, much of which ended up being ignored (which is fine, but
then don't put my name to it).

Cheers,
Lawrence