svn commit: r214380 - head/sys/x86/x86

Attilio Rao attilio at freebsd.org
Tue Oct 26 17:58:07 UTC 2010


2010/10/26 Dimitry Andric <dim at freebsd.org>:
> On 2010-10-26 18:16, Attilio Rao wrote:
>>
>>   Remove usage of PRI* macro for style compliancy.
>
> ...
>>
>> -       printf("  chunk %d: %"PRIu64"MB (%"PRIu64" pages)", seqnr,
>> PG2MB(pgs),
>> -           pgs);
>> +       printf("  chunk %d: %jdMB (%jd pages)", seqnr,
>> (uintmax_t)PG2MB(pgs),
>> +           (uintmax_t)pgs);
>
> If you cast to uintmax_t, you should use %ju instead. :)  Otherwise,
> cast to intmax_t, e.g. if the PG2MB macro results in a signed value.

This bug was already existing with the old version, but yes, you and
Bruce are obviously right.

Thanks,
Attilio


-- 
Peace can only be achieved by understanding - A. Einstein


More information about the svn-src-head mailing list