svn commit: r215750 - head/sys/kern

Andriy Gapon avg at FreeBSD.org
Tue Nov 23 14:30:23 UTC 2010


Author: avg
Date: Tue Nov 23 14:30:22 2010
New Revision: 215750
URL: http://svn.freebsd.org/changeset/base/215750

Log:
  taskqueue: drop unused tq_name field
  
  tq_name was used write-only and besides it was just a pointer, so it
  could point to some garbage in a temporary buffer that's gone.
  This change shouldn't change KPI/KBI as struct taskqueue is private to
  subr_taskqueue.c.
  If we find a need for tq_name it can be resurrected at any moment.
  taskqueue_create() interface is preserved for this purpose.
  
  Suggested by:	jhb
  MFC after:	10 days

Modified:
  head/sys/kern/subr_taskqueue.c

Modified: head/sys/kern/subr_taskqueue.c
==============================================================================
--- head/sys/kern/subr_taskqueue.c	Tue Nov 23 14:13:12 2010	(r215749)
+++ head/sys/kern/subr_taskqueue.c	Tue Nov 23 14:30:22 2010	(r215750)
@@ -53,7 +53,6 @@ struct taskqueue_busy {
 
 struct taskqueue {
 	STAILQ_HEAD(, task)	tq_queue;
-	const char		*tq_name;
 	taskqueue_enqueue_fn	tq_enqueue;
 	void			*tq_context;
 	TAILQ_HEAD(, taskqueue_busy) tq_active;
@@ -94,7 +93,7 @@ TQ_SLEEP(struct taskqueue *tq, void *p, 
 }
 
 static struct taskqueue *
-_taskqueue_create(const char *name, int mflags,
+_taskqueue_create(const char *name __unused, int mflags,
 		 taskqueue_enqueue_fn enqueue, void *context,
 		 int mtxflags, const char *mtxname)
 {
@@ -106,7 +105,6 @@ _taskqueue_create(const char *name, int 
 
 	STAILQ_INIT(&queue->tq_queue);
 	TAILQ_INIT(&queue->tq_active);
-	queue->tq_name = name;
 	queue->tq_enqueue = enqueue;
 	queue->tq_context = context;
 	queue->tq_spin = (mtxflags & MTX_SPIN) != 0;


More information about the svn-src-head mailing list