svn commit: r215304 - head/sys/kern
Bruce Evans
brde at optusnet.com.au
Mon Nov 15 02:53:05 UTC 2010
On Sun, 14 Nov 2010, Bruce Cran wrote:
> Log:
> Fix some more style(9) issues.
Better, but still has style bug(s) on almost every changed line...
> Modified: head/sys/kern/kern_proc.c
> ==============================================================================
> --- head/sys/kern/kern_proc.c Sun Nov 14 15:31:59 2010 (r215303)
> +++ head/sys/kern/kern_proc.c Sun Nov 14 16:10:15 2010 (r215304)
> @@ -145,7 +145,7 @@ uma_zone_t proc_zone;
>
> int kstack_pages = KSTACK_PAGES;
> SYSCTL_INT(_kern, OID_AUTO, kstack_pages, CTLFLAG_RD, &kstack_pages, 0,
> - "Kernel stack size in pages");
> + "Kernel stack size in pages");
... Long SYSCTL declarations are conventionally always split after CTLFLAG*
but aren't here...
> Modified: head/sys/kern/kern_tc.c
> ==============================================================================
> --- head/sys/kern/kern_tc.c Sun Nov 14 15:31:59 2010 (r215303)
> +++ head/sys/kern/kern_tc.c Sun Nov 14 16:10:15 2010 (r215304)
> @@ -770,7 +770,7 @@ pps_event(struct pps_state *pps, int eve
>
> static int tc_tick;
> SYSCTL_INT(_kern_timecounter, OID_AUTO, tick, CTLFLAG_RD, &tc_tick, 0,
> - "Approximate number of hardclock ticks in a millisecond");
> + "Approximate number of hardclock ticks in a millisecond");
...or here...
> void
> tc_ticktock(int cnt)
>
> Modified: head/sys/kern/subr_clock.c
> ==============================================================================
> --- head/sys/kern/subr_clock.c Sun Nov 14 15:31:59 2010 (r215303)
> +++ head/sys/kern/subr_clock.c Sun Nov 14 16:10:15 2010 (r215304)
> @@ -61,7 +61,7 @@ int tz_dsttime;
> * kern.
> */
> SYSCTL_INT(_machdep, OID_AUTO, wall_cmos_clock,
> - CTLFLAG_RW, &wall_cmos_clock, 0, "CMOS clock keeps wall time");
> + CTLFLAG_RW, &wall_cmos_clock, 0, "CMOS clock keeps wall time");
...or here... (this one was an older mistake, split just before CTLFLAG*
instead of long after).
> @@ -74,8 +74,8 @@ sysctl_machdep_adjkerntz(SYSCTL_HANDLER_
> }
>
> SYSCTL_PROC(_machdep, OID_AUTO, adjkerntz, CTLTYPE_INT|CTLFLAG_RW,
> - &adjkerntz, 0, sysctl_machdep_adjkerntz, "I",
> - "Local offset from UTC in seconds");
> + &adjkerntz, 0, sysctl_machdep_adjkerntz, "I",
> + "Local offset from UTC in seconds");
This one had normal splitting, but has the common bug of missing spaces
around the binary operator "|", and had its single continuation line
misindented. Then recent changes duplicated the misindentation of the
coninued line. You fixed a lot of old bugs of this form.
...
Bruce
More information about the svn-src-head
mailing list