svn commit: r214961 - head/usr.bin/yacc

Juli Mallett jmallett at FreeBSD.org
Mon Nov 8 01:54:43 UTC 2010


David,

On Sun, Nov 7, 2010 at 15:22, David E. O'Brien <obrien at freebsd.org> wrote:
> Author: obrien
> Date: Sun Nov  7 23:22:42 2010
> New Revision: 214961
> URL: http://svn.freebsd.org/changeset/base/214961
>
> Log:
>  Directly use memory allocation functions and remove needless casts in
>  their usage.  Also use associated modern types instead of k&r ones.

You do know that changing skeleton.c affects the generated files,
right?  I'm wondering if whatever sed script you're
judiciously-applying knows that.  C++ does not do implicit conversions
from "void *" so you need the casts on the mallocs there.

With a C++ compiler:

y.tab.c:116: error: invalid conversion from 'void*' to 'short int*'
y.tab.c:122: error: invalid conversion from 'void*' to 'YYSTYPE*'

Please back out the changes to the skeleton.


More information about the svn-src-head mailing list