svn commit: r205013 - in head/sys: amd64/amd64 i386/i386

[Alexander Best]

John Baldwin schrieb am 2010-03-11:
> On Thursday 11 March 2010 12:01:28 pm Alexander Best wrote:
> > thanks for the commit. :)

> > a few thoughts:

> > 1) why does stepping remain to be printed in dec while family and
> >    model are in
> > hex? is this the way amd/intel cpu docs refer to
> > stepping/model/family?

> I just left it the way it was.

> > 2) the hex value for "Id" and "(AMD) Features(2)" gets printed with
> >    an "0x"
> > prepended to indicate it's in hex. maybe this should also be the
> > case here.

> Because on a typical Intel system you overflow 80 cols if you do
> that. :(
> Otherwise I would have.  We could maybe add an 'h' suffix as that is
> what
> the manuals and it would only add 2 chars rather than 4.

ah i see. not an easy decision. i wouldn't use the 'h' suffix, because there
should be only one way of relating to a hex value and i believe the overall
convention in freebsd is '0x'.so better keep it the way it is. maybe using %X
instead of %x in the printfs makes the output look a bit nicer, but that's
just eyecandy. ;)

cheers.
alex