svn commit: r205024 - head/sys/net

[Qing Li]

I guess it's a good time to clean things up. The if_link_state code has been
around for quite some time, either it be fully utilized or not be there at all.
The inconsistency is the root cause.

I will try going through these tonight and hopefully the fix all take a
common approach.

-- Qing


On Thu, Mar 11, 2010 at 3:35 PM, Juli Mallett <jmallett at freebsd.org> wrote:
> On Thu, Mar 11, 2010 at 15:30, Qing Li <qingli at freebsd.org> wrote:
>>>
>>> A couple of questions:
>>>
>>> (1) It used to be the case that quite a few interface drivers and types
>>> didn't have a notion of "link up" -- especially older ethernet devices.  Do
>>> those all have the same problem?  It was probably a design oversight that
>>> devices don't declare an explicit capability for "can report link state".
>>>
>>
>>  What you raised is definitely a possibility and these fixes take the
>>  similar approach. I am going to try and go through each of these
>>  drivers in /sys/dev/ and converting them, very soon.
>
> Go through drivers in the embedded port directories, too.  The Octeon
> port's Ethernet driver was broken by this, and it looks like the
> Atheros if_arge is probably broken, too.  I would even suggest going
> back to the old behavior briefly while the port maintainers are given
> an opportunity to update their drivers.  Actually, it looks like only
> MIPS has Ethernet drivers outside of dev/ at a quick glance, but I'd
> be surprised if there weren't other broken examples.
>
> Juli.
>