svn commit: r209060 - head/sys/dev/ixgbe

Jack Vogel jfvogel at gmail.com
Fri Jun 11 20:27:38 UTC 2010


OK, that's kinda what I was guessing... Damn, guess I'll have to change it
back.

Thanks for letting me know.

Jack


On Fri, Jun 11, 2010 at 1:23 PM, Bjoern A. Zeeb <bz at freebsd.org> wrote:

> On Fri, 11 Jun 2010, Jack Vogel wrote:
>
>  Odd though, because that code is in the driver on a system with 16 cores
>> and
>> I'm
>> not hearing about any problem from my test engineer.
>>
>
> So this makes it all go away:
>
> --- //depot/user/bz/vimage/src/sys/dev/ixgbe/ixgbe.c    2010-06-09
> 07:53:30.000000000 0000
> +++ /zoo/bz/p4/bz_vimage/src/sys/dev/ixgbe/ixgbe.c      2010-06-09
> 07:53:30.000000000 0000
> --- /tmp/tmp.96356.27   2010-06-11 16:19:14.000000000 -0400
> +++ /zoo/bz/p4/bz_vimage/src/sys/dev/ixgbe/ixgbe.c      2010-06-11
> 16:16:02.000000000 -0400
> @@ -3637,7 +3637,7 @@ ixgbe_setup_receive_ring(struct rx_ring
>                        goto skip_head;
>
>                /* First the header */
> -               rxbuf->m_head = m_gethdr(M_WAITOK, MT_DATA);
> +               rxbuf->m_head = m_gethdr(M_DONTWAIT, MT_DATA);
>                if (rxbuf->m_head == NULL) {
>                        error = ENOBUFS;
>                        goto fail;
> @@ -3659,7 +3659,7 @@ ixgbe_setup_receive_ring(struct rx_ring
>
>  skip_head:
>                /* Now the payload cluster */
> -               rxbuf->m_pack = m_getjcl(M_WAITOK, MT_DATA,
> +               rxbuf->m_pack = m_getjcl(M_DONTWAIT, MT_DATA,
>                    M_PKTHDR, adapter->rx_mbuf_sz);
>                if (rxbuf->m_pack == NULL) {
>                        error = ENOBUFS;
>
>
> Are they running with WITNESS enabled to see the locking warnings?
>
> /bz
>


More information about the svn-src-head mailing list