svn commit: r208988 - in head/sys: kern sys

[Kostik Belousov]

On Fri, Jun 11, 2010 at 12:09:43PM +0300, Alexander Motin wrote:
> Kostik Belousov wrote:
> > On Thu, Jun 10, 2010 at 04:14:05PM +0000, Alexander Motin wrote:
> >> Author: mav
> >> Date: Thu Jun 10 16:14:05 2010
> >> New Revision: 208988
> >> URL: http://svn.freebsd.org/changeset/base/208988
> >>
> >> Log:
> >>   Store interrupt trap frame into struct thread. It allows interrupt handler
> >>   to obtain both trap frame and opaque argument submitted on registrction.
> >>   After kernel and all drivers get used to it, legacy hack can be removed.
> >>   
> >>   Reviewed by:	jhb@
> > Just curious, why td_frame is not enough for your usage ? I believe td_frame
> > is currently set only by traps and syscalls, and copied on forks.
Correction: and ast().
> 
> I've seen that field, but I have no idea how it is used. I see a lot of
> usage places and not sure that none of them called inside interrupt
> filter. I didn't want to break something unexpected. If you sure - it is
> easy to change.
I believe it is safe to use it in a way that you intended to use
td_intr_frame. In the current code, interrupt handler cannot rely on
the content of td_frame, your save/restore brackets should do the right
thing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20100611/d03dda32/attachment.pgp