svn commit: r210321 - head/lib/libelf

Alexey Dokuchaev danfe at FreeBSD.org
Wed Jul 21 11:29:38 UTC 2010


On Wed, Jul 21, 2010 at 07:51:49PM +1000, Bruce Evans wrote:
> On Wed, 21 Jul 2010, Alexey Dokuchaev wrote:
> >On Wed, Jul 21, 2010 at 08:43:48AM +0000, Kai Wang wrote:
> >>Log:
> >>  Remove a superfluous comment.
> >>
> >>  Obtained from:	     elftoolchain
> >>  MFC after:	     1 month
> >
> >(Just picking random of the similar commits): guys, please, try to
> >uniformly align commit meta tags:
> 
> It is perfectly aligned with tabs (and no 2-char commit mail indentation,
> and no N-char mailer quoting).

Right,  I miscalculated spaces (by hand).  Sorry for false alarm (other
cases still stand though).

> >Obtained from:	somewhere
> >MFC after:	sometime
> >Foo bar:	baz qux ...
> >
> >Broken alignment considerably pessimizes commit log grasping, as it
> >requires more post-processing work after reading it off.
> 
> Do you mean for human grasping and automated post-processing?

Human grasping.

> "tags" should mean the part before the ":".  Aligning those by making them
> all of the same length would help.

That's what I usually mean by tags.  I should have probably explicitly
said that tags' "values" are often misaligned.

Thanks for straightening this out Bruce.

./danfe


More information about the svn-src-head mailing list