svn commit: r210263 - head/sys/dev/bce

[Pyun YongHyeon]

On Tue, Jul 20, 2010 at 10:13:03AM +0000, Bjoern A. Zeeb wrote:
> On Mon, 19 Jul 2010, Pyun YongHyeon wrote:
> 
> >Author: yongari
> >Date: Mon Jul 19 21:41:54 2010
> >New Revision: 210263
> >URL: http://svn.freebsd.org/changeset/base/210263
> >
> >Log:
> > Do not report current link state if interface is not UP.
> 
> 
> Hmm, not sure what exactly the code change does but by your
> description I think I would like to be able to see a porper (updated)
> result in the media: line of ifconfig no matter if it's UP or not.
> 
> If this doesn't change that behaviour, just ignore me;)
> 

I'm afraid this change will effectively disable that feature.
Why you need to know current link state if interface is DOWN?
Note, the reported link state, when interface is in DOWN, could be
wrong because driver will restart auto-negotiation. With this
change it will just say current media.

BEFORE this change:
bce3: flags=8802<BROADCAST,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=c01bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,VLAN_HWTSO,LINKSTATE>
        ether 00:10:18:3e:13:3e
        media: Ethernet autoselect (none)
        status: no carrier
OR if it manage to establish link:
bce3: flags=8802<BROADCAST,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=c01bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,VLAN_HWTSO,LINKSTATE>
        ether 00:10:18:3e:13:3e
        media: Ethernet autoselect (1000baseT <full-duplex,flag1>)
        status: active

AFTER this change:
bce3: flags=8802<BROADCAST,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=c01bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,VLAN_HWTSO,LINKSTATE>
        ether 00:10:18:3e:13:3e
        media: Ethernet autoselect