svn commit: r198858 - in head/sys: dev/fb dev/syscons sys

[Alexey Dokuchaev]

On Tue, Jan 26, 2010 at 03:00:35PM +0100, Dag-Erling Sm??rgrav wrote:
> Alexey Dokuchaev <danfe at FreeBSD.org> writes:
> > Apparently this revision broke logo screen saver w/ vesa.ko on i386 (it
> > works, but image is significantly darker).
> 
> A darker image indicates that the BIOS is in 8-bit mode but the driver
> thinks it's in 6-bit mode, so the driver right-shifts the palette
> entries by two bits.

Yup, I eventually started to think this is the case after reading
through the code and the patch jkim@ sent me privately (which fixed the
issue).

Considering number of recent vesa/saver breaks, I am thinking about some
regression test suit that could at least check for "8-bit vs. 6-bit" type
of things.  Is it feasible?

./danfe