moving sctp to a separate directory ? (Re: svn commit: r201523 - head/sys/netinet)

[Philip Paeps]

On 2010-01-04 23:23:23 (+0100), Luigi Rizzo <rizzo at iet.unipi.it> wrote:
> This was the reason why I moved ipfw-related stuff out of the way
> and plan to do the same with tcp unless someone precedes me.

Please discuss this on -net or so first.  I have worked in an environment
where tcp was moved out of netinet when it was imported (around 2.2.8-time)
and it opens the door to a number of strange phenomena.

What do you do with udp, for instance?  Compared to tcp and sctp, it's
trivial in terms of code, but it's an upper layer protocol from the
perspective of netinet/netinet6 - do we put it in its own directory too?

Also note that this won't only cause churn for people who have patches against
or (out-of-tree) branches from netinet/, but also in other kernel subsystems
which rely on tcp -- nfs, for instance.

I would be very hesitant to do this...

> Just checked, in 2.2 (which was some 12 years ago) netinet/
> had 46 files and 21k lines, of which tcp accounted for 13 files/6K lines.
> Compare with 156 files/153k lines (tcp: 24 files, 16k lines) in HEAD now.

TCP has got a bit more complicated in its old age. :-)

I think the naming convention we have under netinet/ is clear enough...  We
don't pay per dirent these days.

 - Philip

-- 
Philip Paeps                                    Please don't Cc me, I am
philip at freebsd.org                               subscribed to the list.