svn commit: r203696 - in head: lib/libc/sys sys/kern sys/sys

[Kostik Belousov]

On Wed, Feb 10, 2010 at 08:20:37PM -0800, Marcel Moolenaar wrote:
> 
> On Feb 10, 2010, at 1:15 AM, Kostik Belousov wrote:
> > 
> > Vnode locks are before vm map locks in global lock order. vn_fullpath()
> > may need to lock vnodes to call VOP_VPTOCNP(). I think you should (and
> > can) drop both vm map lock and vmspace reference much earlier.
> > 
> > Would it be cleaner to use explicitely sized types for compat32
> > structure members ?
> 
> I don't know. I prefer to keep them identical for as much as
> that's possible.
> 
> > Comparing ptrace_vm_entry with kinfo_vmentry, I think that it might
> > be good idea to add fsid and inode number to ptrace_vm_entry, to
> > give at least some information when vn_fullpath failed.
> 
> How about the attached new path (includes man page as well)?
> 

Looks good to me.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20100211/a79426e9/attachment.pgp