svn commit: r216694 - head/libexec/rtld-elf

[Kostik Belousov]

On Tue, Dec 28, 2010 at 10:09:40AM -0500, John Baldwin wrote:
> On Tuesday, December 28, 2010 8:32:47 am Kostik Belousov wrote:
> > On Tue, Dec 28, 2010 at 02:29:43PM +0100, Ulrich Sp??rlein wrote:
> > > On Sat, 25.12.2010 at 08:42:38 +0000, Konstantin Belousov wrote:
> > > > Author: kib
> > > > Date: Sat Dec 25 08:42:38 2010
> > > > New Revision: 216694
> > > > URL: http://svn.freebsd.org/changeset/base/216694
> > > > 
> > > > Log:
> > > >   Add a hook to pass debug flags to the build of rtld when doing make in
> > > >   the rtld directory.
> > > >   
> > > >   Reviewed by:	kan
> > > 
> > > Please revert this, $(VAR) is against style, and passing DEBUG_FLAGS is
> > > the canonical way to achieve what you wanted, eg. make DEBUG_FLAGS=-g is
> > > working just fine for me.
> > DEBUG_FLAGS=-g might be fine for you, but it does not do what rtld debugging
> > needs. Look at the -DDEBUG.
> > 
> > If you want ${} instead of $(), feel free to change.
> 
> Err, why can't you use 'make DEBUG_FLAGS=-DDEBUG' or
> 'make DEBUG_FLAGS="-g -DDEBUG"'?
> 
> If you are just doing 'make DEBUG=-DDEBUG' with this change, then I agree
> with Ulrich, DEBUG_FLAGS is already suitable for this purpose.
> 
I previously had a version that used RTLD_DEBUG, that I set from make.conf.
Now I do make DEBUG_FLAGS="-g" DEBUG="-DDEBUG". The patch allows to
force the compilation of dbg() without affecting global DEBUG_FLAGS settings.

All big patches to rtld have -DDEBUG addition, and I tired trying to
not forget removing them before the commit.

Anyway, if somebody wants to revert the whole commit, feel free,
I will return to local patching.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20101228/041c4b3b/attachment.pgp