svn commit: r206497 - in head: sbin/geom/class sbin/geom/class/sched sys/geom/sched sys/modules/geom sys/modules/geom/geom_sched sys/modules/geom/geom_sched/gs_sched sys/modules/geom/geom_sched/gsc...

[Pawel Jakub Dawidek]

On Wed, Apr 14, 2010 at 09:46:17AM +0200, Pawel Jakub Dawidek wrote:
> BTW. So you decided to implement insert/remove functionality after all.
> I have some questions:
> 
> - It is implemented as internal gsched hack, which is a pity, because
>   this might be very useful functionality for other classes in the future.
>   Is there a plan to make it more general and move it to the GEOM itself?
> 
> - Why g_sched_flush_pending() operates on global structure? I think it
>   will break if you try to insert and remove at the same time.

One more thing:)

If I read code correctly, new provider has different name than the
original one. If my userland tool send command to my class and my class
tries to find provider by name by scaning existing geoms, it won't find
it, because provider's name is different.

Wouldn't it better to change old provider's name and use the name old
provider had for new provider? Sounds hackish...

Another thing that comes to my mind is possibility to create providers
that are not represented in /dev/. Name collision wouldn't be a problem
then. Also, it seems nicer to not polute /dev/ with such
proxy-providers.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20100414/2693829e/attachment.pgp