svn commit: r206129 - head/sys/kern

[Kostik Belousov]

On Mon, Apr 05, 2010 at 12:11:06AM +0300, Andriy Gapon wrote:
> on 05/04/2010 00:03 Peter Jeremy said the following:
> > On 2010-Apr-03 08:39:00 +0000, Andriy Gapon <avg at FreeBSD.org> wrote:
> >> Author: avg
> >> Date: Sat Apr  3 08:39:00 2010
> >> New Revision: 206129
> >> URL: http://svn.freebsd.org/changeset/base/206129
> >>
> >> Log:
> >>  vn_stat: take into account va_blocksize when setting st_blksize
> >>  
> >>  As currently st_blksize is always PAGE_SIZE, it is playing safe to not
> >>  use any smaller value.  For some cases this might not be optimal, but
> >>  at least nothing should get broken.
> > 
> > I haven't verified it but, based on a quick look at the change, I
> > suspect this will trigger the problem in bin/144446.  Quick summary:
> > db(3) has restrictions on its internal bucket size but initializes it
> > from st_blksize with no sanity checking and ZFS can report blocksizes
> > outside the allowed bucket size range for db(3).
> > 
> 
> Thank you for pointing this out.
> If no one objects or provides a better patch, I will commit yours.

I do not think this is very satisfying solution. Pre-patched libc
still suffer from the problem. You cannot run stable/8 libc on this
kernel.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20100404/db30549d/attachment.pgp