svn commit: r196769 - in head/sys: amd64/amd64 i386/i386

[Marko Zec]

On Thursday 03 September 2009 22:51:47 Jung-uk Kim wrote:
> On Thursday 03 September 2009 04:25 pm, Marko Zec wrote:
> > On Wednesday 02 September 2009 18:02:48 Jung-uk Kim wrote:
> > > Author: jkim
> > > Date: Wed Sep  2 16:02:48 2009
> > > New Revision: 196769
> > > URL: http://svn.freebsd.org/changeset/base/196769
> > >
> > > Log:
> > >   - Work around ACPI mode transition problem for recent NVIDIA
> > > 9400M chipset based Intel Macs.  Since r189055, these platforms
> > > started freezing when ACPI is being initialized for unknown
> > > reason.  For these platforms, we just use the old PAT layout.
> > > Note this change is not enough to boot fully on these platforms
> > > because of other problems but it makes debugging possible. Note
> > > MacBook5,2 may be affected as well but it was not added here
> > > because of lack of hardware to test.
> > >   - Initialize PAT MSR fully instead of reading and modifying it
> > > for safety.
> >
> > Perhaps I'm missing something, but I fail to understand what is the
> > purpose / use of variable pat_tested here?
>
> Without it, bad things may happen while APs are being initialized in
> SMP case.

Ouch, OK, only now I see that pat_tested is declared static - I thought it was 
reset to 0 at each pmap_init_pat() call...

Sorry for the noise,

Marko