svn commit: r197740 - head/sys/fs/tmpfs

Xin LI delphij at FreeBSD.org
Sun Oct 4 10:38:05 UTC 2009


Author: delphij
Date: Sun Oct  4 10:38:04 2009
New Revision: 197740
URL: http://svn.freebsd.org/changeset/base/197740

Log:
  Fix a bug that causes the fsx test case of mmap'ed page being out of sync
  of read/write, inspired by ZFS's counterpart.
  
  PR:		kern/139312
  Submitted by:	gk@
  MFC after:	1 week

Modified:
  head/sys/fs/tmpfs/tmpfs_vnops.c

Modified: head/sys/fs/tmpfs/tmpfs_vnops.c
==============================================================================
--- head/sys/fs/tmpfs/tmpfs_vnops.c	Sun Oct  4 09:57:39 2009	(r197739)
+++ head/sys/fs/tmpfs/tmpfs_vnops.c	Sun Oct  4 10:38:04 2009	(r197740)
@@ -444,7 +444,8 @@ tmpfs_mappedread(vm_object_t vobj, vm_ob
 	offset = addr & PAGE_MASK;
 	tlen = MIN(PAGE_SIZE - offset, len);
 
-	if ((vobj == NULL) || (vobj->resident_page_count == 0))
+	if ((vobj == NULL) ||
+	    (vobj->resident_page_count == 0 && vobj->cache == NULL))
 		goto nocache;
 
 	VM_OBJECT_LOCK(vobj);
@@ -555,7 +556,8 @@ tmpfs_mappedwrite(vm_object_t vobj, vm_o
 	offset = addr & PAGE_MASK;
 	tlen = MIN(PAGE_SIZE - offset, len);
 
-	if ((vobj == NULL) || (vobj->resident_page_count == 0)) {
+	if ((vobj == NULL) ||
+	    (vobj->resident_page_count == 0 && vobj->cache == NULL)) {
 		vpg = NULL;
 		goto nocache;
 	}
@@ -573,6 +575,8 @@ lookupvpg:
 		VM_OBJECT_UNLOCK(vobj);
 		error = uiomove_fromphys(&vpg, offset, tlen, uio);
 	} else {
+		if (__predict_false(vobj->cache != NULL))
+			vm_page_cache_free(vobj, idx, idx + 1);
 		VM_OBJECT_UNLOCK(vobj);
 		vpg = NULL;
 	}


More information about the svn-src-head mailing list