svn commit: r199785 - head/lib/libc/rpc

[Garrett Wollman]

Author: wollman
Date: Wed Nov 25 04:49:41 2009
New Revision: 199785
URL: http://svn.freebsd.org/changeset/base/199785

Log:
  In svc_raw_reply(), don't leave stat uninitialized if the MSG_ACCEPTED
  && SUCCESS case succeeds.  The stack garbage might be zero.
  
  Found by:	Clang static analyzer
  MFC after:	7 days

Modified:
  head/lib/libc/rpc/svc_raw.c

Modified: head/lib/libc/rpc/svc_raw.c
==============================================================================
--- head/lib/libc/rpc/svc_raw.c	Wed Nov 25 04:45:45 2009	(r199784)
+++ head/lib/libc/rpc/svc_raw.c	Wed Nov 25 04:49:41 2009	(r199785)
@@ -176,9 +176,8 @@ svc_raw_reply(xprt, msg)
 		msg->acpted_rply.ar_results.proc = (xdrproc_t) xdr_void;
 		msg->acpted_rply.ar_results.where = NULL;
 
-		if (!xdr_replymsg(xdrs, msg) ||
-		    !SVCAUTH_WRAP(&SVC_AUTH(xprt), xdrs, xdr_proc, xdr_where))
-			stat = FALSE;
+		stat = xdr_replymsg(xdrs, msg) &&
+		    SVCAUTH_WRAP(&SVC_AUTH(xprt), xdrs, xdr_proc, xdr_where);
 	} else {
 		stat = xdr_replymsg(xdrs, msg);
 	}