svn commit: r199538 - head/sys/dev/lmc

[Julian Elischer]

John Baldwin wrote:
> On Thursday 19 November 2009 1:38:42 pm Julian Elischer wrote:
>> John Baldwin wrote:
>>> Author: jhb
>>> Date: Thu Nov 19 18:21:51 2009
>>> +#  if (__FreeBSD_version >= 500000)
>>> +  callout_init(&sc->callout, 0);
>>> +#  else  /* FreeBSD-4 */
>>> +  callout_init(&sc->callout);
>>> +#  endif
>>> +
>>
>> I think the OpenBSD and _FreeBSD_version >= 500000
>> conditions can probably be removed..
>>
>>
>>>  
>>>  #ifdef __FreeBSD__
>>> +  struct callout callout;	/* watchdog needs this                  */
>>>    struct device	*dev;		/* base device pointer                     */
>>>    bus_space_tag_t csr_tag;	/* bus_space needs this                    */
>>>    bus_space_handle_t csr_handle;/* bus_space_needs this                    
> */
>> along with #ifdef __FreeBSD__
> 
> Go for it. :)  I was just removing if_watchdog use in this sweep.  No one 
> stepped up to test this since I posted it almost 2 weeks ago though, so I'm 
> not sure if there are any users of this.
> 

I didn't realize it was an externally maintained driver...

stripping saves some space..
-rw-r--r--    1 root  wheel  212883 Nov 19 11:54 if_lmc.c
-rw-r--r--    1 root  wheel   76600 Nov 19 11:54 if_lmc.h
-rw-r--r--    1 root  wheel  142163 Nov 19 13:41 stripped.c
-rw-r--r--    1 root  wheel   61537 Nov 19 13:47 stripped.h

but I'll ask the author first..