svn commit: r192440 - in head/sys: amd64/amd64 i386/i386

John Baldwin jhb at FreeBSD.org
Wed May 20 16:11:23 UTC 2009


Author: jhb
Date: Wed May 20 16:11:22 2009
New Revision: 192440
URL: http://svn.freebsd.org/changeset/base/192440

Log:
  Don't bother reading the initial value of the machine check banks during
  startup on Pentium 4 CPUs.  This wasn't safe to do on APs during AP startup,
  was of limited value, and won't be used for future processors.

Modified:
  head/sys/amd64/amd64/mca.c
  head/sys/i386/i386/mca.c

Modified: head/sys/amd64/amd64/mca.c
==============================================================================
--- head/sys/amd64/amd64/mca.c	Wed May 20 15:11:20 2009	(r192439)
+++ head/sys/amd64/amd64/mca.c	Wed May 20 16:11:22 2009	(r192440)
@@ -491,10 +491,6 @@ mca_init(void)
 			if (!(i == 0 && (cpu_id & 0xf00) == 0x600))
 				wrmsr(MSR_MC_CTL(i), 0xffffffffffffffffUL);
 
-			/* XXX: Better CPU test needed here. */
-			if ((cpu_id & 0xf00) == 0xf00)
-				mca_record_entry(i);
-
 			/* Clear all errors. */
 			wrmsr(MSR_MC_STATUS(i), 0);
 		}

Modified: head/sys/i386/i386/mca.c
==============================================================================
--- head/sys/i386/i386/mca.c	Wed May 20 15:11:20 2009	(r192439)
+++ head/sys/i386/i386/mca.c	Wed May 20 16:11:22 2009	(r192440)
@@ -491,10 +491,6 @@ mca_init(void)
 			if (!(i == 0 && (cpu_id & 0xf00) == 0x600))
 				wrmsr(MSR_MC_CTL(i), 0xffffffffffffffffUL);
 
-			/* XXX: Better CPU test needed here. */
-			if ((cpu_id & 0xf00) == 0xf00)
-				mca_record_entry(i);
-
 			/* Clear all errors. */
 			wrmsr(MSR_MC_STATUS(i), 0);
 		}


More information about the svn-src-head mailing list