svn commit: r190593 - head/lib/libstand

John Baldwin jhb at FreeBSD.org
Tue Mar 31 07:30:48 PDT 2009


Author: jhb
Date: Tue Mar 31 14:30:46 2009
New Revision: 190593
URL: http://svn.freebsd.org/changeset/base/190593

Log:
  Fix an off-by-one buffer overflow in ngets().
  
  Submitted by:	Bruce Can
  MFC after:	1 month

Modified:
  head/lib/libstand/gets.c

Modified: head/lib/libstand/gets.c
==============================================================================
--- head/lib/libstand/gets.c	Tue Mar 31 12:51:49 2009	(r190592)
+++ head/lib/libstand/gets.c	Tue Mar 31 14:30:46 2009	(r190593)
@@ -74,7 +74,7 @@ ngets(char *buf, int n)
 	    putchar('\n');
 	    break;
 	default:
-	    if ((n < 1) || ((lp - buf) < n)) {
+	    if ((n < 1) || ((lp - buf) < n - 1)) {
 		*lp++ = c;
 		putchar(c);
 	    }


More information about the svn-src-head mailing list