svn commit: r189828 - in head: include sys/sys

[Vasil Dimov]

On Fri, Mar 20, 2009 at 12:44:55 -0400, Coleman Kane wrote:
[...]
> > > On Fri, Mar 20, 2009, Vasil Dimov wrote:
> > >   
> > >> On Sat, Mar 14, 2009 at 08:10:14PM +0000, David Schultz wrote:
> > >>     
> > >>> Author: das
> > >>> Date: Sat Mar 14 20:10:14 2009
> > >>> New Revision: 189828
> > >>> URL: http://svn.freebsd.org/changeset/base/189828
> > >>>
> > >>> Log:
> > >>>   Fix the visibility of several prototypes. Also move pthread_kill() and
> > >>>   pthread_sigmask() to signal.h. In principle, this shouldn't break anything,
> > >>>       
> > >> [...]
> > >>
> > >> But it did break, see http://www.freebsd.org/cgi/query-pr.cgi?pr=132828
[...]
> I was able to solve the problem by removing the "#include <signal.h>"
> from the offending file (there is only one) in devel/pth. After that, it
> built fine and I am using it now.
[...]

Hi,

I do not have access to 8-current machine so I have some dump questions:

1. From which file did you remove "#include <signal.h>"? I am afraid
that if we remove it from pth_p.h.in then this problem could arise again
after the user has installed pth and is trying to use it and has
included signal.h for some other reason in his source. I.e. if pth's
pthread.h and the system's signal.h are included in one source file this
problem will resurface.

2. Hmm, why are the prototypes conflicting in the first place?
extern int pthread_kill(pthread_t, int);
int pthread_kill(__pthread_t, int);

3. /usr/include/signal.h defines pthread_kill() only if __POSIX_VISIBLE
or __XSI_VISIBLE is defined. Can someone try to inject
#undef __POSIX_VISIBLE or #undef __XSI_VISIBLE into pth's pthread.h.in
to see if this fixes the problem and does not cause other problems?

Thank you!

-- 
Vasil Dimov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 163 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20090327/a630b8c3/attachment.pgp