svn commit: r190170 - head/sys/dev/drm

Robert Noland rnoland at FreeBSD.org
Fri Mar 20 11:35:17 PDT 2009


Author: rnoland
Date: Fri Mar 20 18:35:16 2009
New Revision: 190170
URL: http://svn.freebsd.org/changeset/base/190170

Log:
  vm_offset_t is unsigned, so compare of >= 0 is not needed.
  
  Found with:	Coverity Prevent(tm)
  CID:		2259
  
  MFC after:	3 days

Modified:
  head/sys/dev/drm/drm_vm.c

Modified: head/sys/dev/drm/drm_vm.c
==============================================================================
--- head/sys/dev/drm/drm_vm.c	Fri Mar 20 18:30:20 2009	(r190169)
+++ head/sys/dev/drm/drm_vm.c	Fri Mar 20 18:35:16 2009	(r190170)
@@ -54,7 +54,7 @@ int drm_mmap(struct cdev *kdev, vm_offse
 	if (file_priv && !file_priv->authenticated)
 		return EACCES;
 
-	if (dev->dma && offset >= 0 && offset < ptoa(dev->dma->page_count)) {
+	if (dev->dma && offset < ptoa(dev->dma->page_count)) {
 		drm_device_dma_t *dma = dev->dma;
 
 		DRM_SPINLOCK(&dev->dma_lock);


More information about the svn-src-head mailing list