svn commit: r190163 - head/sys/dev/drm

Robert Noland rnoland at FreeBSD.org
Fri Mar 20 10:48:37 PDT 2009


Author: rnoland
Date: Fri Mar 20 17:48:36 2009
New Revision: 190163
URL: http://svn.freebsd.org/changeset/base/190163

Log:
  Don't deref dev->dev_private before checking that it exists.
  
  Found with:	Coverity Prevent(tm)
  CID:		2940
  
  MFC after:	3 days

Modified:
  head/sys/dev/drm/i915_drv.c

Modified: head/sys/dev/drm/i915_drv.c
==============================================================================
--- head/sys/dev/drm/i915_drv.c	Fri Mar 20 17:11:45 2009	(r190162)
+++ head/sys/dev/drm/i915_drv.c	Fri Mar 20 17:48:36 2009	(r190163)
@@ -46,9 +46,8 @@ static drm_pci_id_list_t i915_pciidlist[
 static int i915_suspend(device_t kdev)
 {
 	struct drm_device *dev = device_get_softc(kdev);
-	struct drm_i915_private *dev_priv = dev->dev_private;
 
-	if (!dev || !dev_priv) {
+	if (!dev || !dev->dev_private) {
 		DRM_ERROR("dev: 0x%lx, dev_priv: 0x%lx\n",
 			(unsigned long) dev, (unsigned long) dev_priv);
 		DRM_ERROR("DRM not initialized, aborting suspend.\n");


More information about the svn-src-head mailing list