svn commit: r189625 - head/sys/geom/eli

[Fabian Keil]

Guido van Rooij <guido at FreeBSD.org> wrote:

> Author: guido
> Date: Tue Mar 10 15:23:43 2009
> New Revision: 189625
> URL: http://svn.freebsd.org/changeset/base/189625
> 
> Log:
>   When attaching a geli on boot make sure that it is detached
>   upon last close. (needed for a gmirror to properly shutdown
>   upon reboot when a geli is on top the gmirror)
> 
> Modified:
>   head/sys/geom/eli/g_eli.c
> 
> Modified: head/sys/geom/eli/g_eli.c
> ==============================================================================
> --- head/sys/geom/eli/g_eli.c	Tue Mar 10 15:19:49 2009
> (r189624) +++ head/sys/geom/eli/g_eli.c	Tue Mar 10 15:23:43
> 2009	(r189625) @@ -996,6 +996,7 @@ g_eli_taste(struct g_class
> *mp, struct g /*
>  	 * We have correct key, let's attach provider.
>  	 */
> +	md.md_flags |= G_ELI_FLAG_WO_DETACH;
>  	gp = g_eli_create(NULL, mp, pp, &md, mkey, nkey);
>  	bzero(mkey, sizeof(mkey));
>  	bzero(&md, sizeof(md));

Detach-on-last-close is known to cause panics when
scrubbing at least some ZFS pools:
http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/117158

Quoting the PR:
|Quoting Pawel Jakub Dawidek's response to my initial report:
||GELI's detach-on-last-close mechanism is a general purpose mechanism, it
||may not work correctly with ZFS, because ZFS sometimes closes and reopen
||providers, which will make GELI to detach. In other words you shouldn't
||configure detach-on-last-close for ZFS components. 

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20090310/5dac0db7/signature.pgp