svn commit: r195907 - in head/sys: amd64/amd64 i386/i386

Sam Leffler sam at errno.com
Fri Jul 31 17:00:53 UTC 2009


Ed Schouten wrote:
> * Rui Paulo <rpaulo at FreeBSD.org> wrote:
>> Refine the MacBook hack to only match early models that have Intel ICH.
> ...
>> -		if (strncmp(sysenv, "MacBook", 7) == 0) {
>> +		if (strncmp(sysenv, "MacBook1,1", 10) == 0 ||
>> +		    strncmp(sysenv, "MacBookPro1,1", 13) == 0 ||
>> +		    strncmp(sysenv, "MacBookPro1,2", 13) == 0 ||
>> +		    strncmp(sysenv, "Macmini1,1", 10) == 0) {
> 
> Yay -- this change broke FreeBSD on my MacBook3,1. Could we please add
> MacBook3,1 to this list before releasing 8.0?
> 

A hack like this deserves a loader tunable to set the list or, perhaps 
easier, an extra model ID to allow workaround w/o rebuilding (e.g. for 
doing an install).

	Sam



More information about the svn-src-head mailing list