svn commit: r195772 - head/usr.sbin/ppp

Brian Somers brian at FreeBSD.org
Sun Jul 19 19:01:31 UTC 2009


Author: brian
Date: Sun Jul 19 19:01:30 2009
New Revision: 195772
URL: http://svn.freebsd.org/changeset/base/195772

Log:
  Don't get stuck in an infinite loop comparing (short++ <= maxshort)
  
  PR:		136893
  Submitted by:	Aragon Gouveia - aragon at phat dot za dot net (mostly)
  Approved by:	re (kib)
  MFC after:	3 weeks

Modified:
  head/usr.sbin/ppp/nat_cmd.c

Modified: head/usr.sbin/ppp/nat_cmd.c
==============================================================================
--- head/usr.sbin/ppp/nat_cmd.c	Sun Jul 19 18:37:20 2009	(r195771)
+++ head/usr.sbin/ppp/nat_cmd.c	Sun Jul 19 19:01:30 2009	(r195772)
@@ -175,7 +175,7 @@ nat_RedirectPort(struct cmdargs const *a
       return -1;
     }
 
-    while (laliasport <= haliasport) {
+    do {
       link = LibAliasRedirectPort(la, localaddr, htons(llocalport),
 				     remoteaddr, htons(lremoteport),
                                      aliasaddr, htons(laliasport),
@@ -187,10 +187,9 @@ nat_RedirectPort(struct cmdargs const *a
         return 1;
       }
       llocalport++;
-      laliasport++;
       if (hremoteport)
         lremoteport++;
-    }
+    } while (laliasport++ < haliasport);
 
     return 0;
   }


More information about the svn-src-head mailing list