svn commit: r186751 - in head/sys: netinet6 netipsec

Steve Kargl sgk at
Mon Jan 5 12:43:58 PST 2009

On Mon, Jan 05, 2009 at 07:45:47PM +0000, Bjoern A. Zeeb wrote:
> On Mon, 5 Jan 2009, Christoph Mallon wrote:
> Hi,
> >Bjoern A. Zeeb schrieb:
> >>I have broken it out from a larger patch; the C99 initializer is here:
> >>
> >>
> >>I case someone can give it a quick glance I'll commit them.
> >
> >+	.pr_flags	= PR_ATOMIC|PR_ADDR,
> >
> >style(9) wants spaces around binary operators.
> I am not sure it does. In case it does I am not going to break
> consistency with all other 65 places that don't do for pr_flags;
> but it seems I should change the <tab>=<space> to <space>=<tab>.
> Thanks for making me look, and thanks for review!

>From style(9):

    Unary operators do not require spaces, binary operators do.


    Stylistic changes (including whitespace changes) are hard on
	the source repository and are to be avoided without good reason. 

So, it appears your change conforms to the prevailing style of the
file, and is acceptable.


More information about the svn-src-head mailing list