svn commit: r200806 - head/usr.sbin/newsyslog

Stanislav Sedov stas at FreeBSD.org
Tue Dec 22 23:21:47 UTC 2009


On Tue, 22 Dec 2009 14:10:22 -0800
Xin LI <delphij at delphij.net> mentioned:

> On 2009/12/22 13:32, Stanislav Sedov wrote:
> > On Mon, 21 Dec 2009 20:12:02 +0000 (UTC)
> > Xin LI<delphij at FreeBSD.org>  mentioned:
> >
> >> Author: delphij
> >> Date: Mon Dec 21 20:12:01 2009
> >> New Revision: 200806
> >> URL: http://svn.freebsd.org/changeset/base/200806
> >>
> >> Log:
> >>    Don't consider non-existence of a PID file an error, we should be able
> >>    to proceed anyway as this most likely mean that the process has been
> >>    terminated.
> >
> > Or the process has not created the PID file and can be screwed up by rotating
> > its log file.  What about making this optional controlled by a command line
> > switch?  It might be a more safe alternative.
> 
> Yes probably.  I think the both case (can't find the PID file, or the 
> PID file is empty) should be counted, as they may represent the similar 
> situation, however, I think we'd better leave the current behavior 
> default, since it's the most case.
> 
> Do you think the attached patch makes sense?
> 

Yeah, thank you, it looks fine.

In my opinion, though, I'd left the old behavior as default, as it is somewhat safer.
But maybe I'm just too paranoic.:-)

-- 
Stanislav Sedov
ST4096-RIPE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20091222/b6cb1c74/attachment-0001.pgp


More information about the svn-src-head mailing list