svn commit: r200055 - head/sys/netinet/ipfw

Hajimu UMEMOTO ume at FreeBSD.org
Fri Dec 4 03:45:17 UTC 2009


Hi,

>>>>> On Thu, 3 Dec 2009 19:43:33 +0000 (UTC)
>>>>> "Bjoern A. Zeeb" <bz at FreeBSD.org> said:

bz> Does it need to be 48 rather than 46? You do not have the [] here.
bz> If not INET6_ADDRSTRLEN is what we use elsewhere.  I would actually
bz> prefer to only have
bz> #ifdef INET6
bz>  	char src[INET6_ADDRSTRLEN|48], ..
bz> #else
bz>  	char src[INET_ADDRSTRLEN|18], ..
bz> #endif

bz> as it's 60 bytes of stack size for people w/o INET6 support (shame on
bz> them;-)  Some applies for equivalent code further down.

Oops, I'll fix it later.

Sincerely,

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume at mahoroba.org  ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/


More information about the svn-src-head mailing list