svn commit: r196478 - head/etc
Doug Barton
dougb at FreeBSD.org
Mon Aug 24 22:05:49 UTC 2009
Christoph Mallon wrote:
> Doug Barton schrieb:
>> Author: dougb
>> Date: Sun Aug 23 19:52:47 2009
>> New Revision: 196478
>> URL: http://svn.freebsd.org/changeset/base/196478
>>
>> Log:
>> Prior to the dire warning about values of network_interfaces other than
>> AUTO the biggest mistake users made was leaving lo0 off the list. Since
>> lo0 is effectively mandatory, check for it and add it to the list if
>> it's not there.
>>
>> Modified:
>> head/etc/network.subr
>>
>> Modified: head/etc/network.subr
>> ==============================================================================
>>
>> --- head/etc/network.subr Sun Aug 23 18:28:58 2009 (r196477)
>> +++ head/etc/network.subr Sun Aug 23 19:52:47 2009 (r196478)
>> @@ -727,6 +727,13 @@ list_net_interfaces()
>> ;;
>> *)
>> _tmplist="${network_interfaces} ${cloned_interfaces}"
>> +
>> + # lo0 is effectively mandatory, so help prevent foot-shooting
>> + #
>> + case "$_tmplist" in
>> + lo0*|*lo0|*' lo0 '*) ;; # This is fine, do nothing
>
> Doesn't this also match malo0?
> IMO the test should be lo0|'lo0 '*|*' lo0'|*' lo0 '*.
Thank you for the suggestion, I've just committed it. :)
Doug
--
This .signature sanitized for your protection
More information about the svn-src-head
mailing list