svn commit: r196358 - in head: share/man/man9 sys/kern sys/sys

Pawel Jakub Dawidek pjd at FreeBSD.org
Tue Aug 18 18:39:04 UTC 2009


On Tue, Aug 18, 2009 at 08:06:17PM +0200, Attilio Rao wrote:
> 2009/8/18 Sam Leffler <sam at errno.com>:
> > Pawel Jakub Dawidek wrote:
> >>
> >> Author: pjd
> >> Date: Tue Aug 18 13:55:48 2009
> >> New Revision: 196358
> >> URL: http://svn.freebsd.org/changeset/base/196358
> >>
> >> Log:
> >>  Remove unused taskqueue_find() function.
> >>    Reviewed by:  dfr
> >>  Approved by:  re (kib)
> >
> > I don't understand why this should be removed (let alone during a code
> > freeze).  I can think of several uses for this function including a ddb cmd
> > that takes a taskq name and dumps it's contents.  The overhead of
> > maintaining the global list appears minimal.
> 
> FWIW, I agree with Sam.

The only use I could think of was exactly what Sam suggested - a DDB
command and that was the only possible use I found.

I decided to propose removal of this KPI, because nobody decided to use
it for more than 9 years now and this is a good thing to remove unused
code, no?

I won't fight for keeping it removed, really. If after 9 years someone
will find it useful I'm all for bringing it back.

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20090818/a2d7ffbc/attachment.pgp


More information about the svn-src-head mailing list