svn commit: r191369 - in head/sys: arm/conf dev/iicbus

[M. Warner Losh]

In message: <20090423091120.18706t1ks38zgfgo at webmail.leidinger.net>
            Alexander Leidinger <Alexander at leidinger.net> writes:
: Quoting "M. Warner Losh" <imp at bsdimp.com> (from Wed, 22 Apr 2009  
: 13:31:47 -0600 (MDT)):
: 
: > In message: <20090422231511.ca92fb9f.stas at FreeBSD.org>
: >             Stanislav Sedov <stas at FreeBSD.org> writes:
: > : On Wed, 22 Apr 2009 09:05:46 +0200
: > : Alexander Leidinger <Alexander at Leidinger.net> mentioned:
: > :
: > : > Quoting "M. Warner Losh" <imp at bsdimp.com> (from Wed, 22 Apr 2009
: > : > 00:26:43 -0600 (MDT)):
: > : >
: > : > > In message: <200904212248.n3LMmCbu027432 at svn.freebsd.org>
: > : > >             Stanislav Sedov <stas at FreeBSD.org> writes:
: > : > > : Author: stas
: > : > > : Date: Tue Apr 21 22:48:12 2009
: > : > > : New Revision: 191369
: > : > > : URL: http://svn.freebsd.org/changeset/base/191369
: > : > > :
: > : > > : Log:
: > : > > :   - Rename ds1672 and ds133x devices to "ds1672_rtc" and "ds133x_rtc"
: > : > > :     respectivly. This will allow one to have a kernel with  
: > both devices
: > : > > :     present and use it for multiple boards with different  
: > types of RTC
: > : > > :     sitting on a bus.
: > : > > :
: > : > > :   Discussed with:	imp
: > : > >
: > : > > Hey thanks Stas!  Now things are better than before both functionally
: > : > > and cosmetically!  Good idea on the names...
: > : >
: > : > <devils_advocate>
: > : > Are those the first devices with an underscore in the name now? If
: > : > yes, do we want this?
: > : > </devils_advocate>
: > : >
: > :
: > : I had the same concerns too, but was not able to come up with anything
: > : better. BTW, I think those devices were the first that ended with a
: > : digit.
: 
: ds1672rtc?   Just if it pleases you or we do not want underscores in  
: device names which are visible to the outside.

There's no rule against understores right now.

: > No.  They weren't.  There are sound devices that end in digits:
: >
: > # snd_ad1816:		Analog Devices AD1816 ISA PnP/non-PnP.
: > # snd_als4000:		Avance Logic ALS4000 PCI.
: > # snd_cs4281:		Crystal Semiconductor CS4281 PCI.
: > # snd_ds1:		Yamaha DS-1 PCI.
: > # snd_emu10k1:		Creative EMU10K1 PCI and EMU10K2 (Audigy) PCI.
: > # snd_envy24:		VIA Envy24 and compatible, needs snd_spicds.
: > # snd_fm801:		Forte Media FM801 PCI.
: > # snd_maestro3:		ESS Technology Maestro-3/Allegro PCI.
: > # snd_sb16:		Creative SoundBlaster16, to be used in
: > # snd_sb8:		Creative SoundBlaster (pre-16), to be used in
: > # snd_via8233:		VIA VT8233x PCI.
: > # snd_via82c686:	VIA VT82C686A PCI.
: >
: > but since they all live on an enumerated bus, they all share the name
: > "pcm".
: 
: And because of this they don't count as being with underscores...

Why not?

Warner