svn commit: r191114 - head/sys/pc98/cbus

Ed Schouten ed at 80386.nl
Wed Apr 15 20:58:18 UTC 2009


Hello John,

* John Baldwin <jhb at freebsd.org> wrote:
> When I performed similar changes in lpt(4) I stored the flags in si_drv2 
> instead of the minor number.  You might want to do the same here so the 
> drivers are closer.

I guess in the very far future we'll hopefully just get rid of
dev2unit() and allow the struct field that stores the unit number
(si_drv0) to be used by the drivers directly. An advantage of the unit
number is that it's an integer type, unlike si_drv1 and si_drv2.

I guess it's good to just leave it the way it is right now, because it
was the least intrusive way to fix it like this and best of all, if I
ever get the chance to remove dev2unit(), I'm forced to let it use
si_drv0 instead of keeping evil casts from/to pointers.

-- 
 Ed Schouten <ed at 80386.nl>
 WWW: http://80386.nl/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20090415/3cd10cc7/attachment.pgp


More information about the svn-src-head mailing list