svn commit: r184193 - in head/sys: arm/conf conf

[John Baldwin]

On Friday 24 October 2008 12:01:55 pm Sam Leffler wrote:
> Warner Losh wrote:
> > From: Marcel Moolenaar <marcel at FreeBSD.org>
> > Subject: svn commit: r184193 - in head/sys: arm/conf conf
> > Date: Thu, 23 Oct 2008 01:51:55 +0000 (UTC)
> >
> >   
> >> Author: marcel
> >> Date: Thu Oct 23 01:51:55 2008
> >> New Revision: 184193
> >> URL: http://svn.freebsd.org/changeset/base/184193
> >>
> >> Log:
> >>   Add arm/conf/DEFAULTS and populate it with:
> >>           machine arm
> >>           device  mem
> >>           options GEOM_BSD
> >>           options GEOM_MBR
> >>   
> >>   Remove the first two from all kernel configuration files and
> >>   change geom_bsd and geom_mbr from standard to optional.
> >>
> >> Added:
> >>   head/sys/arm/conf/DEFAULTS   (contents, props changed)
> >>     
> >
> > We already have a better mechanism for including config files.  We
> > should be using that instead of poluting another port with the
> > DEFAULTS file.
> >   
> More importantly this change forces GEOM_BSD and GEOM_MBR on every 
> target platform.  This is just wrong and clearly Marvel never discussed 
> it with anyone working on arm systems or he'd have gotten an earful.
> 
> Marcel, please back this stuff out.

Sam,

I have to say that if you look at what Marcel did, he actually helped your 
cause.  Previously, any ARM kernel you built _always_ had GEOM_BSD and 
GEOM_MBR in unless you hacked sys/conf/files.arm.  Now you can just 
put 'nooptions GEOM_BSD' or 'nooptions GEOM_MBR' in your kernel config to 
remove them without having to hack sys/conf/files.arm.  This is a step 
forward, not a step backwards.  Of course, you are always free to add 
explicit GEOM_MBR/GEOM_BSD lines to the ARM configs that need it and then 
remove them from DEFAULTS.  But this change 1) preserves people's existing 
kernel configs to still do the same thing as before and 2) introduces the 
_new_ ability to turn off GEOM_MBR/GEOM_BSD that _wasn't_ _there_ _before_ 
without local hacks.

-- 
John Baldwin