svn commit: r183690 - head/sys/kern

Robert Watson rwatson at FreeBSD.org
Wed Oct 8 06:26:52 UTC 2008


Author: rwatson
Date: Wed Oct  8 06:26:51 2008
New Revision: 183690
URL: http://svn.freebsd.org/changeset/base/183690

Log:
  Remove stale comment (and XXX saying so) about why we zero the file
  descriptor pointer in unp_freerights: we can no longer recurse into
  unp_gc due to unp_gc being invoked in a deferred way, but it's still
  a good idea.
  
  MFC after:	3 days

Modified:
  head/sys/kern/uipc_usrreq.c

Modified: head/sys/kern/uipc_usrreq.c
==============================================================================
--- head/sys/kern/uipc_usrreq.c	Wed Oct  8 06:19:49 2008	(r183689)
+++ head/sys/kern/uipc_usrreq.c	Wed Oct  8 06:26:51 2008	(r183690)
@@ -1538,12 +1538,6 @@ unp_freerights(struct file **rp, int fdc
 	struct file *fp;
 
 	for (i = 0; i < fdcount; i++) {
-		/*
-		 * Zero the pointer before calling unp_discard since it may
-		 * end up in unp_gc()..
-		 *
-		 * XXXRW: This is less true than it used to be.
-		 */
 		fp = *rp;
 		*rp++ = NULL;
 		unp_discard(fp);


More information about the svn-src-head mailing list