svn commit: r185026 - head/sys/crypto/via

Philip Paeps philip at FreeBSD.org
Mon Nov 17 11:00:37 PST 2008


Author: philip
Date: Mon Nov 17 19:00:36 2008
New Revision: 185026
URL: http://svn.freebsd.org/changeset/base/185026

Log:
  Fix a potential NULL-pointer dereference in padlock(4).
  
  Spotted by:	Coverity (via pjd)
  MFC after:	1 week

Modified:
  head/sys/crypto/via/padlock.c

Modified: head/sys/crypto/via/padlock.c
==============================================================================
--- head/sys/crypto/via/padlock.c	Mon Nov 17 18:45:07 2008	(r185025)
+++ head/sys/crypto/via/padlock.c	Mon Nov 17 19:00:36 2008	(r185026)
@@ -297,7 +297,11 @@ padlock_process(device_t dev, struct cry
 
 	enccrd = maccrd = NULL;
 
-	if (crp == NULL || crp->crp_callback == NULL || crp->crp_desc == NULL) {
+	/* Sanity check. */
+	if (crp == NULL)
+		return (EINVAL);
+
+	if (crp->crp_callback == NULL || crp->crp_desc == NULL) {
 		error = EINVAL;
 		goto out;
 	}


More information about the svn-src-head mailing list