svn commit: r184668 - head/usr.bin/tar/test
Tim Kientzle
tim at kientzle.com
Tue Nov 4 23:06:31 PST 2008
Xin LI wrote:
>>Author: kientzle
>>Date: Wed Nov 5 05:26:11 2008
>>New Revision: 184668
>>URL: http://svn.freebsd.org/changeset/base/184668
>>
>>
>[...]
>
>
>>@@ -494,7 +494,8 @@ test_assert_empty_file(const char *f1fmt
>> if (fd < 0) {
>> fprintf(stderr, " Unable to open %s\n", f1);
>> } else {
>>- s = sizeof(buff) < st.st_size ? sizeof(buff) : st.st_size;
>>+ s = (sizeof(buff) < (size_t)st.st_size) ?
>>+ (ssize_t)sizeof(buff) : (ssize_t)st.st_size;
>>
>>
>
>I'm more or less concerned about this - st_size is off_t, is it safe to
>cast it to size_t when comparing here?
>
>
Thanks. I've fixed this.
Tim
More information about the svn-src-head
mailing list